On Tue, Oct 20, 2015 at 09:07:49AM +0200, Thomas Monjalon wrote:
> 2015-10-09 13:46, Yuanhan Liu:
> > From: Changchun Ouyang <changchun.ouyang at intel.com>
> >
> > The old code adjusts the config bytes we want to read depending on
> > what kind of features we have, but we later cast the entire buf we
> > read with "struct virtio_net_config", which is obviously wrong.
>
> When describing a bug, it is important to explain what is the consequence,
> i.e. which use case is failing. If it is only to prepare the new feature,
> it is better to clearly state that the bug had no impact until now.
>
> And as usual, the "fix" word in the title and the "Fixes" tag are required.
What's the right way supposed to use "Fixes" tag, BTW? Checking the git
hisotry, I saw something like:
Fixes: $commit_hash ($commit_log).
Which basically means it's a regression fix. However, in this case, it's
more than like a bug, but not a regression.
--yliu
