On 10/01/2024 15:21, Ferruh Yigit wrote:
On 1/10/2024 2:58 PM, Maryam Tahhan wrote:
Hi folks
Just wondering if there's any other comments re this patch after all the
review comments were addressed?
Hi Maryam,
There was a request from David, to the previous version, that fixes
(either to code or document) should be separated into its own patch, so
that they can be merged to our LTS (say 21.11.x) releases, to make sure
LTS release has correct info/code. On top of it your changes can be
another patch.
As document completely changed, it is not easy for me to say, can you
please confirm that there is no fix to the documentation unrelated with
your code change?
Hey Ferruh
Yes - I should've clarified. I took David's comments into consideration.
The old use_cni implementation is broken (so if a DPDK pod wants
multiple AF_XDP interfaces it will not work). So IMHO it doesn't make
sense to patch documentation for something that is broken. The whole
change would need to be back ported to LTS.
However, I have a second change to apply on top of this - so I will send
a series. So please hold off merging for now.
BR
Maryam
