Not necessary to return fail when starting or stopping a queue if the queue was already at required state.
Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> --- drivers/net/ice/ice_rxtx.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 73e47ae92d..3286bb08fe 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -673,6 +673,10 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) return -EINVAL; } + if (dev->data->rx_queue_state[rx_queue_id] == + RTE_ETH_QUEUE_STATE_STARTED) + return 0; + if (dev->data->dev_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) rxq->ts_enable = true; err = ice_program_hw_rx_queue(rxq); @@ -717,6 +721,10 @@ ice_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) if (rx_queue_id < dev->data->nb_rx_queues) { rxq = dev->data->rx_queues[rx_queue_id]; + if (dev->data->rx_queue_state[rx_queue_id] == + RTE_ETH_QUEUE_STATE_STOPPED) + return 0; + err = ice_switch_rx_queue(hw, rxq->reg_idx, false); if (err) { PMD_DRV_LOG(ERR, "Failed to switch RX queue %u off", @@ -758,6 +766,10 @@ ice_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) return -EINVAL; } + if (dev->data->tx_queue_state[tx_queue_id] == + RTE_ETH_QUEUE_STATE_STARTED) + return 0; + buf_len = ice_struct_size(txq_elem, txqs, 1); txq_elem = ice_malloc(hw, buf_len); if (!txq_elem) @@ -1066,6 +1078,10 @@ ice_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id) return -EINVAL; } + if (dev->data->tx_queue_state[tx_queue_id] == + RTE_ETH_QUEUE_STATE_STOPPED) + return 0; + q_ids[0] = txq->reg_idx; q_teids[0] = txq->q_teid; -- 2.31.1