Fix places leading to a log message not terminated with a newline.
Cc: sta...@dpdk.org
Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Stephen Hemminger <step...@networkplumber.org>
Reviewed-by: Tyler Retzlaff <roret...@linux.microsoft.com>
Reviewed-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
---
lib/eal/common/eal_common_options.c | 2 +-
lib/eal/linux/eal_hugepage_info.c | 2 +-
lib/eal/linux/eal_interrupts.c | 2 +-
lib/ethdev/ethdev_pci.h | 2 +-
lib/ethdev/rte_ethdev.c | 40 ++++++++++++++---------------
lib/lpm/rte_lpm6.c | 6 ++---
lib/power/guest_channel.c | 2 +-
lib/power/rte_power_pmd_mgmt.c | 6 ++---
8 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/lib/eal/common/eal_common_options.c
b/lib/eal/common/eal_common_options.c
index a6d21f1cba..e9ba01fb89 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -2141,7 +2141,7 @@ rte_vect_set_max_simd_bitwidth(uint16_t bitwidth)
struct internal_config *internal_conf =
eal_get_internal_configuration();
if (internal_conf->max_simd_bitwidth.forced) {
- RTE_LOG(NOTICE, EAL, "Cannot set max SIMD bitwidth - user
runtime override enabled");
+ RTE_LOG(NOTICE, EAL, "Cannot set max SIMD bitwidth - user
runtime override enabled\n");
return -EPERM;
}
diff --git a/lib/eal/linux/eal_hugepage_info.c
b/lib/eal/linux/eal_hugepage_info.c
index 581d9dfc91..36a495fb1f 100644
--- a/lib/eal/linux/eal_hugepage_info.c
+++ b/lib/eal/linux/eal_hugepage_info.c
@@ -403,7 +403,7 @@ inspect_hugedir_cb(const struct walk_hugedir_data *whd)
struct stat st;
if (fstat(whd->file_fd, &st) < 0)
- RTE_LOG(DEBUG, EAL, "%s(): stat(\"%s\") failed: %s",
+ RTE_LOG(DEBUG, EAL, "%s(): stat(\"%s\") failed: %s\n",
__func__, whd->file_name, strerror(errno));
else
(*total_size) += st.st_size;
diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c
index d4919dff45..eabac24992 100644
--- a/lib/eal/linux/eal_interrupts.c
+++ b/lib/eal/linux/eal_interrupts.c
@@ -1542,7 +1542,7 @@ rte_intr_efd_enable(struct rte_intr_handle *intr_handle,
uint32_t nb_efd)
/* only check, initialization would be done in vdev driver.*/
if ((uint64_t)rte_intr_efd_counter_size_get(intr_handle) >
sizeof(union rte_intr_read_buffer)) {
- RTE_LOG(ERR, EAL, "the efd_counter_size is oversized");
+ RTE_LOG(ERR, EAL, "the efd_counter_size is
oversized\n");
return -EINVAL;
}
} else {
diff --git a/lib/ethdev/ethdev_pci.h b/lib/ethdev/ethdev_pci.h
index 320e3e0093..ddb559aa95 100644
--- a/lib/ethdev/ethdev_pci.h
+++ b/lib/ethdev/ethdev_pci.h
@@ -31,7 +31,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,
struct rte_pci_device *pci_dev)
{
if ((eth_dev == NULL) || (pci_dev == NULL)) {
- RTE_ETHDEV_LOG(ERR, "NULL pointer eth_dev=%p pci_dev=%p",
+ RTE_ETHDEV_LOG(ERR, "NULL pointer eth_dev=%p pci_dev=%p\n",
(void *)eth_dev, (void *)pci_dev);
return;
}
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 3858983fcc..b9d99ece15 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -724,7 +724,7 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t
*port_id)
uint16_t pid;
if (name == NULL) {
- RTE_ETHDEV_LOG(ERR, "Cannot get port ID from NULL name");
+ RTE_ETHDEV_LOG(ERR, "Cannot get port ID from NULL name\n");
return -EINVAL;
}
@@ -2394,41 +2394,41 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id,
uint16_t rx_queue_id,
nb_rx_desc = cap.max_nb_desc;
if (nb_rx_desc > cap.max_nb_desc) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for nb_rx_desc(=%hu), should be: <= %hu",
+ "Invalid value for nb_rx_desc(=%hu), should be: <=
%hu\n",
nb_rx_desc, cap.max_nb_desc);
return -EINVAL;
}
if (conf->peer_count > cap.max_rx_2_tx) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for number of peers for Rx queue(=%u),
should be: <= %hu",
+ "Invalid value for number of peers for Rx queue(=%u),
should be: <= %hu\n",
conf->peer_count, cap.max_rx_2_tx);
return -EINVAL;
}
if (conf->use_locked_device_memory && !cap.rx_cap.locked_device_memory)
{
RTE_ETHDEV_LOG(ERR,
- "Attempt to use locked device memory for Rx queue,
which is not supported");
+ "Attempt to use locked device memory for Rx queue,
which is not supported\n");
return -EINVAL;
}
if (conf->use_rte_memory && !cap.rx_cap.rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to use DPDK memory for Rx queue, which is not
supported");
+ "Attempt to use DPDK memory for Rx queue, which is not
supported\n");
return -EINVAL;
}
if (conf->use_locked_device_memory && conf->use_rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to use mutually exclusive memory settings for
Rx queue");
+ "Attempt to use mutually exclusive memory settings for
Rx queue\n");
return -EINVAL;
}
if (conf->force_memory &&
!conf->use_locked_device_memory &&
!conf->use_rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to force Rx queue memory settings, but none is
set");
+ "Attempt to force Rx queue memory settings, but none is
set\n");
return -EINVAL;
}
if (conf->peer_count == 0) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for number of peers for Rx queue(=%u),
should be: > 0",
+ "Invalid value for number of peers for Rx queue(=%u),
should be: > 0\n",
conf->peer_count);
return -EINVAL;
}
@@ -2438,7 +2438,7 @@ rte_eth_rx_hairpin_queue_setup(uint16_t port_id, uint16_t
rx_queue_id,
count++;
}
if (count > cap.max_nb_queues) {
- RTE_ETHDEV_LOG(ERR, "To many Rx hairpin queues max is %d",
+ RTE_ETHDEV_LOG(ERR, "To many Rx hairpin queues max is %d\n",
cap.max_nb_queues);
return -EINVAL;
}
@@ -2597,41 +2597,41 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id,
uint16_t tx_queue_id,
nb_tx_desc = cap.max_nb_desc;
if (nb_tx_desc > cap.max_nb_desc) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for nb_tx_desc(=%hu), should be: <= %hu",
+ "Invalid value for nb_tx_desc(=%hu), should be: <=
%hu\n",
nb_tx_desc, cap.max_nb_desc);
return -EINVAL;
}
if (conf->peer_count > cap.max_tx_2_rx) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for number of peers for Tx queue(=%u),
should be: <= %hu",
+ "Invalid value for number of peers for Tx queue(=%u),
should be: <= %hu\n",
conf->peer_count, cap.max_tx_2_rx);
return -EINVAL;
}
if (conf->use_locked_device_memory && !cap.tx_cap.locked_device_memory)
{
RTE_ETHDEV_LOG(ERR,
- "Attempt to use locked device memory for Tx queue,
which is not supported");
+ "Attempt to use locked device memory for Tx queue,
which is not supported\n");
return -EINVAL;
}
if (conf->use_rte_memory && !cap.tx_cap.rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to use DPDK memory for Tx queue, which is not
supported");
+ "Attempt to use DPDK memory for Tx queue, which is not
supported\n");
return -EINVAL;
}
if (conf->use_locked_device_memory && conf->use_rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to use mutually exclusive memory settings for
Tx queue");
+ "Attempt to use mutually exclusive memory settings for
Tx queue\n");
return -EINVAL;
}
if (conf->force_memory &&
!conf->use_locked_device_memory &&
!conf->use_rte_memory) {
RTE_ETHDEV_LOG(ERR,
- "Attempt to force Tx queue memory settings, but none is
set");
+ "Attempt to force Tx queue memory settings, but none is
set\n");
return -EINVAL;
}
if (conf->peer_count == 0) {
RTE_ETHDEV_LOG(ERR,
- "Invalid value for number of peers for Tx queue(=%u),
should be: > 0",
+ "Invalid value for number of peers for Tx queue(=%u),
should be: > 0\n",
conf->peer_count);
return -EINVAL;
}
@@ -2641,7 +2641,7 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t
tx_queue_id,
count++;
}
if (count > cap.max_nb_queues) {
- RTE_ETHDEV_LOG(ERR, "To many Tx hairpin queues max is %d",
+ RTE_ETHDEV_LOG(ERR, "To many Tx hairpin queues max is %d\n",
cap.max_nb_queues);
return -EINVAL;
}
@@ -6716,7 +6716,7 @@ rte_eth_ip_reassembly_capability_get(uint16_t port_id,
}
if (reassembly_capa == NULL) {
- RTE_ETHDEV_LOG(ERR, "Cannot get reassembly capability to NULL");
+ RTE_ETHDEV_LOG(ERR, "Cannot get reassembly capability to
NULL\n");
return -EINVAL;
}
@@ -6752,7 +6752,7 @@ rte_eth_ip_reassembly_conf_get(uint16_t port_id,
}
if (conf == NULL) {
- RTE_ETHDEV_LOG(ERR, "Cannot get reassembly info to NULL");
+ RTE_ETHDEV_LOG(ERR, "Cannot get reassembly info to NULL\n");
return -EINVAL;
}
@@ -6780,7 +6780,7 @@ rte_eth_ip_reassembly_conf_set(uint16_t port_id,
if (dev->data->dev_configured == 0) {
RTE_ETHDEV_LOG(ERR,
"Device with port_id=%u is not configured.\n"
- "Cannot set IP reassembly configuration",
+ "Cannot set IP reassembly configuration\n",
port_id);
return -EINVAL;
}
diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c
index 873cc8bc26..24ce7dd022 100644
--- a/lib/lpm/rte_lpm6.c
+++ b/lib/lpm/rte_lpm6.c
@@ -280,7 +280,7 @@ rte_lpm6_create(const char *name, int socket_id,
rules_tbl = rte_hash_create(&rule_hash_tbl_params);
if (rules_tbl == NULL) {
- RTE_LOG(ERR, LPM, "LPM rules hash table allocation failed: %s
(%d)",
+ RTE_LOG(ERR, LPM, "LPM rules hash table allocation failed: %s
(%d)\n",
rte_strerror(rte_errno), rte_errno);
goto fail_wo_unlock;
}
@@ -290,7 +290,7 @@ rte_lpm6_create(const char *name, int socket_id,
sizeof(uint32_t) * config->number_tbl8s,
RTE_CACHE_LINE_SIZE);
if (tbl8_pool == NULL) {
- RTE_LOG(ERR, LPM, "LPM tbl8 pool allocation failed: %s (%d)",
+ RTE_LOG(ERR, LPM, "LPM tbl8 pool allocation failed: %s (%d)\n",
rte_strerror(rte_errno), rte_errno);
rte_errno = ENOMEM;
goto fail_wo_unlock;
@@ -301,7 +301,7 @@ rte_lpm6_create(const char *name, int socket_id,
sizeof(struct rte_lpm_tbl8_hdr) * config->number_tbl8s,
RTE_CACHE_LINE_SIZE);
if (tbl8_hdrs == NULL) {
- RTE_LOG(ERR, LPM, "LPM tbl8 headers allocation failed: %s (%d)",
+ RTE_LOG(ERR, LPM, "LPM tbl8 headers allocation failed: %s
(%d)\n",
rte_strerror(rte_errno), rte_errno);
rte_errno = ENOMEM;
goto fail_wo_unlock;
diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index cc05347425..a6f2097d5b 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -90,7 +90,7 @@ guest_channel_host_connect(const char *path, unsigned int
lcore_id)
flags |= O_NONBLOCK;
if (fcntl(fd, F_SETFL, flags) < 0) {
RTE_LOG(ERR, GUEST_CHANNEL, "Failed on setting non-blocking
mode for "
- "file %s", fd_path);
+ "file %s\n", fd_path);
goto error;
}
/* QEMU needs a delay after connection */
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index 38f8384085..6f18ed0adf 100644
--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c
@@ -686,7 +686,7 @@ int
rte_power_pmd_mgmt_set_pause_duration(unsigned int duration)
{
if (duration == 0) {
- RTE_LOG(ERR, POWER, "Pause duration must be greater than 0,
value unchanged");
+ RTE_LOG(ERR, POWER, "Pause duration must be greater than 0,
value unchanged\n");
return -EINVAL;
}
pause_duration = duration;
@@ -709,7 +709,7 @@ rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore,
unsigned int min)
}
if (min > scale_freq_max[lcore]) {
- RTE_LOG(ERR, POWER, "Invalid min frequency: Cannot be greater
than max frequency");
+ RTE_LOG(ERR, POWER, "Invalid min frequency: Cannot be greater
than max frequency\n");
return -EINVAL;
}
scale_freq_min[lcore] = min;
@@ -729,7 +729,7 @@ rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore,
unsigned int max)
if (max == 0)
max = UINT32_MAX;
if (max < scale_freq_min[lcore]) {
- RTE_LOG(ERR, POWER, "Invalid max frequency: Cannot be less than
min frequency");
+ RTE_LOG(ERR, POWER, "Invalid max frequency: Cannot be less than
min frequency\n");
return -EINVAL;
}
--
2.43.0
