On Wed, 13 Dec 2023 09:00:48 +0100 David Marchand <david.march...@redhat.com> wrote:
> On Wed, Dec 13, 2023 at 5:19 AM Stephen Hemminger > <step...@networkplumber.org> wrote: > > > > The generic RTE_LOGTYPE_PMD is a leftover and should be removed. > > As a first step, fix many drivers to not use it, and add a > > helper for the RTE_LOG_DP(). > > I don't see why we need a new rte_log_dp helper. > The #define RTE_LOGTYPE_XXX trick should work fine with RTE_LOG_DP(). > What else is missing? The problem is RTE_LOG_DP() usage today takes suffixes. So the param log type can only be one of the pre-defined fixed values. Changing the macro in one patch would be a huge patch. It seemed best to have RTE_LOG_DP() stay like RTE_LOG() and introduce rte_log_dp() to match rte_log().
