> -----Original Message-----
> From: Bruce Richardson <bruce.richard...@intel.com>
> Sent: Tuesday, December 5, 2023 5:01 PM
> To: dev@dpdk.org
> Cc: Bruce Richardson <bruce.richard...@intel.com>; sta...@dpdk.org;
> Sunil Kumar Kori <sk...@marvell.com>
> Subject: [EXT] [PATCH] buildtools/dpdk-cmdline-gen: fix code gen for IP
> addresses
>
> External Email
>
> ----------------------------------------------------------------------
> The C code generated for the tokens for matching IP addresses in
> commandlines was missing the "static" prefix present in the output for the
> other data-types.
>
> Fixes: 37666691e9ed ("buildtools: add a tool to generate cmdline
> boilerplate")
> Cc: sta...@dpdk.org
>
> Reported-by: Sunil Kumar Kori <sk...@marvell.com>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> buildtools/dpdk-cmdline-gen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/dpdk-cmdline-gen.py b/buildtools/dpdk-cmdline-
> gen.py index 49b03bee4a..bf1253d949 100755
> --- a/buildtools/dpdk-cmdline-gen.py
> +++ b/buildtools/dpdk-cmdline-gen.py
> @@ -71,7 +71,7 @@ def process_command(lineno, tokens, comment):
> elif t_type in ["IP", "IP_ADDR", "IPADDR"]:
> result_struct.append(f"\tcmdline_ipaddr_t {t_name};")
> initializers.append(
> - f"cmdline_parse_token_ipaddr_t cmd_{name}_{t_name}_tok =\n"
> + f"static cmdline_parse_token_ipaddr_t
> cmd_{name}_{t_name}_tok =\n"
> f"\tTOKEN_IPV4_INITIALIZER(struct cmd_{name}_result,
> {t_name});"
> )
> elif t_type.startswith("(") and t_type.endswith(")"):
> --
Acked-by: Sunil Kumar Kori <sk...@marvell.com>
> 2.40.1
