On 11/24/2023 1:36 PM, David Marchand wrote:
> On Fri, Nov 24, 2023 at 4:31 AM Sunyang Wu <sunyang...@jaguarmicro.com> wrote:
>>
>> Fix the issue of incorrect definition of 'NVGRE_ENCAP', and
>> modified the error comments of 'rte_flow_action_nvgre_encap'.
>>
>> Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter")
>> Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions")
>
> Please use the format for Fixes tag described in the contributing guide.
>
> Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object
> converter")
> Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions")
>
>> Cc: sta...@dpdk.org
>
> Copying more maintainers.
> Apart from readability, I think this patch does not fix any real bug, does it?
>
It is a genuine fix, that used struct was wrong, but as size of both
structs are same, practically functionality should be same.
I think risk is low with this patch and we can get it even at this stage
of release, but also it is safe to postpone it to next release. I leave
decision to David.
Reviewed-by: Ferruh Yigit <ferruh.yi...@amd.com>
>>
>> Signed-off-by: Joey Xing <joey.x...@jaguarmicro.com>
>> Signed-off-by: Sunyang Wu <sunyang...@jaguarmicro.com>
>
>
