On 11/23/2023 1:58 AM, Thomas Monjalon wrote: > 26/10/2023 17:19, Sivaprasad Tummala: >> Updated the l3fwd-power app to configure the uncore env before invoking >> any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is >> too late because other APIs already called. > > You are also updating the uncore API. > >> + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT) >> + /* Currently only intel_uncore is supported. This will be >> + * extended with auto-detection support for multiple uncore >> + * implementations. >> + */ >> + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE; > > It looks like this patch does not make sense without AMD support. >
Yes, right now auto detect directly fallback to Intel, but there is an intention to add AMD support too, that is why instead directly using Intel preferred the auto detection abstraction.
