> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, November 21, 2023 12:55 AM > To: Joyce Kong <joyce.k...@arm.com> > Cc: Ruifeng Wang <ruifeng.w...@arm.com>; bruce.richard...@intel.com; > dev@dpdk.org; nd <n...@arm.com> > Subject: Re: [PATCH v3] config/arm: correct cpu arch for cross build > > 20/11/2023 10:24, Joyce Kong: > > The cn10k cross build file sets cpu to 'armv8.6-a' while it is > > armv8.5-a arch. > > Meanwhile, the cpu field in the cross file doesn't take effect as > > config/arm/meson.build controls machine_args for march. Then change > > the 'cpu' value in all arm cross files to 'auto'. > > > > Signed-off-by: Joyce Kong <joyce.k...@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com> > > What did you change compared to v2? > Please take care of providing a changelog after "---" > > I still see the same error on my machine: > config/meson.build:178:8: ERROR: Problem encountered: > Compiler does not support "native" arch flag. >
The patch "config: verify machine arch flag (b7676fcccab4) " introduces a verification for specified cpu_instruction_set. When cpu set to 'auto' as my patch, the below code in config/meson.build changes it to 'native' and triggers the verification error. However, the platform couldn't be 'native' or 'generic' for cross build. Changing cpu_instruction_set from 'auto' to 'native' is unreasonable here. I would like to send a patch to move the below code to not cross build path. "if platform == 'native' if cpu_instruction_set == 'auto' cpu_instruction_set = 'native' endif elif platform == 'generic' if cpu_instruction_set == 'auto' cpu_instruction_set = 'generic' endif endif" And I would like to update cpu value in the cross file to aarch64 instead of auto, to avoid any further possible verification.