On 10/15/15, 2:00 PM, "Alexander Duyck" <alexander.duyck at gmail.com> wrote:

>
>Your changes are a bit over-kill and actually take things in the wrong
>direction.  By commenting out the whole allow_unsupported_sfp block you
>are disabling it by default.  Remember the module parameter allows it,
>by removing it there is no way to enable the feature.
>
>Like I mentioned in my previous email just take a look at replacing the
>"OPTION_DISABLED" value with "OPTION_ENABLED" in the .def part of the
>structure.  After that you won't need to pass the module parameter as it
>will always be enabled by default.
>
>- Alex

It's hard to see in the patch, but I basically replaced that whole option
check block with:

{
        /*
        * allow_unsupported_sfp - Enable/Disable support for unsupported
        * and untested SFP+ modules.
        */
        adapter->hw.allow_unsupported_sfp = true;


}

Alex Forster

Reply via email to