On Fri, Nov 17, 2023 at 02:18:21PM +0100, David Marchand wrote:
> Getting readable and consistent logs is important when running a DPDK
> application, especially when troubleshooting.
> A common issue with logs is when a DPDK change do not add (or on the
> contrary add too many \n) in the format string.
>
> This issue would only get noticed when actually hitting this log (which
> may be something difficult to do).
>
> This series proposes to introduce a new RTE_LOG helper that is
> responsible for logging a one line message and spews a build error (with
> gcc) if any \n is part of the format string.
>
>
> Note:
> - the first patch is intentionnally sent as a single block: splitting it
> into per library commits with correct Fixes: tags is a tedious work.
> I would split it for a non RFC series. For now, it is enough to show
> case the idea.
> - the last patch shows how an existing log macro is converted,
>
>
very nice. I definitely think this should be implemented for 24.03
Thanks,
/Bruce
PS: I'm not even sure that the first patch needs to be split. I think it's
fairly clear as-is.
