13/11/2023 18:56, Patrick Robb: > On Thu, Nov 9, 2023 at 6:17 PM <jspew...@iol.unh.edu> wrote: > > > From: Jeremy Spewock <jspew...@iol.unh.edu> > > > > Modifies the current process so that we bind to os_driver_for_dpdk from > > the configuration file before running test suites and bind back to the > > os_driver afterwards. This allows test suites to assume that the ports > > are bound to a DPDK supported driver or bind to either driver as needed. > > > > Signed-off-by: Jeremy Spewock <jspew...@iol.unh.edu> > > > > We discussed this aspect of binding during last week's CI meeting and I > understood Juraj to be consenting to returning to DTS running the binding > to the dpdk driver (so, what you're doing here), as opposed to relying on > the user to do it, and making it a smoke test. As we've discussed, that's > how the old DTS framework ran, and I prefer to stick to this approach. One > aspect I raised was how in a lab context it's desirable for us to define as > much as possible within config files, and have environmental configuration > be handled by DTS. So, since there was basically agreement here, I think > your changes here are appropriate. > > Acked-by: Patrick Robb <pr...@iol.unh.edu>
Not sure it is a good idea to add something knowing it will be reworked, but you agreed, so I apply. PS: please make all versions of the same patch in the same email thread.