On 11/3/2023 7:38 AM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), > it also supports to parse only-key (e.g. socket_id). But many drivers's > callback can only handle key-value, it will segment fault if handles > only-key. so the patchset [1] was introduced. > > Because the patchset [1] modified too much drivers, therefore: > 1) A new API rte_kvargs_process_opt() was introduced, it inherits the > function of rte_kvargs_process() which could parse both key-value and > only-key. > 2) Constraint the rte_kvargs_process() can only parse key-value. > > This patchset also include one bugfix for kvargs of mvneta driver. > > [1] > https://patches.dpdk.org/project/dpdk/patch/20230320092110.37295-1-fengcheng...@huawei.com/ > > Chengwen Feng (5): > kvargs: add one new process API > net/af_packet: use new API to parse kvargs > net/sfc: use new API to parse kvargs > net/tap: use new API to parse kvargs > net/mvneta: fix possible out-of-bounds write >
Hi Chengwen, I checked the driver code updates above, but it is hard to know if there are more missing, each requires investigating one by one. Perhaps it can be easier to trace back from your original patch [1] and update the ones that doesn't need "value == NULL" check, I assume this is what you did.
