> On 10/24/2023 3:28 AM, Chaoyong He wrote:
> > Introduce the very basic NFP vDPA library.
> >
> > Signed-off-by: Shujing Dong <shujing.d...@corigine.com>
> > Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
> > Reviewed-by: Long Wu <long...@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zh...@corigine.com>
>
> <...>
>
> > --- /dev/null
> > +++ b/drivers/vdpa/nfp/meson.build
> > @@ -0,0 +1,16 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2023
> > +Corigine, Inc.
> > +
> > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> > + build = false
> > + reason = 'only supported on 64-bit Linux'
> > +endif
> > +
> > +if not dpdk_conf.has('RTE_LIB_VHOST')
> > + build = false
> > + reason = 'missing dependency, DPDK vhost library'
> > +endif
> > +
>
> Similar to previous comment, this may break the build.
> Instead of this check, it is possible to add vhost and common/nfp as
> dependency to this driver, using 'deps'.
>
Sorry for that, I will drop it in the next version.
>
> > +sources = files(
> > + 'nfp_vdpa_log.c',
> > +)
> > diff --git a/drivers/vdpa/nfp/nfp_vdpa_log.c
> > b/drivers/vdpa/nfp/nfp_vdpa_log.c new file mode 100644 index
> > 0000000000..8c957d59ea
> > --- /dev/null
> > +++ b/drivers/vdpa/nfp/nfp_vdpa_log.c
> > @@ -0,0 +1,9 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright (c) 2023 Corigine, Inc.
> > + * All rights reserved.
> > + */
> > +
> > +#include "nfp_vdpa_log.h"
> > +
> > +RTE_LOG_REGISTER_SUFFIX(nfp_core_logtype, driver, NOTICE);
> > +RTE_LOG_REGISTER_SUFFIX(nfp_vdpa_logtype, driver, NOTICE);
> >
>
> Both has 'driver' has suffix, I assume copy/paste error.
Thanks point that out, will revise in the next version.
