> On 10/24/2023 3:28 AM, Chaoyong He wrote:
> > Modify the logic of NFP VF PMD, make it using of the NFP common module
> > and link into the 'nfp_drivers_list'.
> >
> > Signed-off-by: Chaoyong He <chaoyong...@corigine.com>
> > Signed-off-by: Shujing Dong <shujing.d...@corigine.com>
> > Reviewed-by: Long Wu <long...@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zh...@corigine.com>
> > ---
> > drivers/net/nfp/meson.build | 6 +++++-
> > drivers/net/nfp/nfp_ethdev_vf.c | 14 ++++++++++----
> > 2 files changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build
> > index 40e9ef8524..f8581403fa 100644
> > --- a/drivers/net/nfp/meson.build
> > +++ b/drivers/net/nfp/meson.build
> > @@ -40,4 +40,8 @@ sources = files(
> > 'nfp_rxtx.c',
> > )
> >
> > -deps += ['hash', 'security']
> > +deps += ['hash', 'security', 'common_nfp']
> > +
> > +if not dpdk_conf.has('RTE_COMMON_NFP')
> > + error('Missing internal dependency "common/nfp"') endif
> >
>
> This will break the build for the cases 'common/nfp' is disabled, above 'deps'
> updates should be sufficient, which should prevent to build the driver when
> 'common/nfp' is missing, instead of failing.
>
> So can you please drop above check.
Okay, will drop it in the next version, thanks.
