Re: [PATCH v8 06/12] app/graph: add ipv4_lookup command line interfaces

[Jerin Jacob]

On Fri, Sep 29, 2023 at 8:16 PM <sk...@marvell.com> wrote:
>
> From: Sunil Kumar Kori <sk...@marvell.com>
>
> It adds ipv4_lookup module to configure LPM table. This LPM table
> will be used for IPv4 lookup and forwarding.
>
> Following commands are exposed:
>  - ipv4_lookup route add ipv4 <ip> netmask <mask> via <ip>
>  - help ipv4_lookup
>
> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
> Signed-off-by: Rakesh Kudurumalla <rkuduruma...@marvell.com>
> ---
>  app/graph/cli.c            |   2 +
>  app/graph/ethdev.c         |   2 +-
>  app/graph/ip4_route.c      | 221 +++++++++++++++++++++++++++++++++++++
>  app/graph/meson.build      |   1 +
>  app/graph/module_api.h     |   1 +
>  app/graph/route.h          |  26 +++++
>  app/graph/route_priv.h     |  44 ++++++++
>  doc/guides/tools/graph.rst |   9 ++
>  8 files changed, 305 insertions(+), 1 deletion(-)
>  create mode 100644 app/graph/ip4_route.c
>  create mode 100644 app/graph/route.h
>  create mode 100644 app/graph/route_priv.h
>
> diff --git a/app/graph/cli.c b/app/graph/cli.c
> index c4b5cf3ce1..430750db6e 100644
> --- a/app/graph/cli.c
> +++ b/app/graph/cli.c
> @@ -30,6 +30,8 @@ cmdline_parse_ctx_t modules_ctx[] = {
>         (cmdline_parse_inst_t *)&ethdev_ip6_cmd_ctx,
>         (cmdline_parse_inst_t *)&ethdev_cmd_ctx,
>         (cmdline_parse_inst_t *)&ethdev_help_cmd_ctx,
> +       (cmdline_parse_inst_t *)&ipv4_lookup_cmd_ctx,
> +       (cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx,
>         NULL,
>  };
>
> diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
> index 74e80679d9..4d2bc73e7c 100644
> --- a/app/graph/ethdev.c
> +++ b/app/graph/ethdev.c
> @@ -160,7 +160,7 @@ ethdev_stop(void)
>         }
>
>         ethdev_list_clean();
> -       rte_eal_cleanup();

Looks like by mistake it is removed in this patch.

> +       route_ip4_list_clean();
>         printf("Bye...\n");
>  }