HI

BR
Rongwei

> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, October 16, 2023 16:20
> To: Rongwei Liu <rongw...@nvidia.com>
> Cc: dev@dpdk.org; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko
> <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; Suanming Mou
> <suanmi...@nvidia.com>; Raslan Darawsheh <rasl...@nvidia.com>
> Subject: Re: [PATCH v3] net/mlx5: add test for live migration
> 
> External email: Use caution opening links or attachments
> 
> 
> 19/09/2023 10:12, Rongwei Liu:
> > This patch adds testpmd app a runtime function to test the live
> > migration API.
> >
> >     testpmd> mlx5 set flow_engine <active|standby> [<flag>] Flag is
> > optional.
> >
> > Signed-off-by: Rongwei Liu <rongw...@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com>
> > Acked-by: Ori Kam <or...@nvidia.com>
> [...]
> > +Set Flow Engine Mode
> > +~~~~~~~~~~~~~~~~~~~~
> > +
> > +Set the flow engine to active(0) or standby(1) mode with specific flags::
> 
> Need space before brackets.
> 
Sure.
> > +
> > +.. code-block:: console
> > +
> > +   testpmd> mlx5 set flow_engine <active|standby> [<flags>]
> 
> What are the flags?
> 
The flag is optional and defined a as bitmap.
For now, only one value is accepted: BIT(0). 
I don't have any idea to propagate the value definition list here. Any 
suggestions?
> > +
> > +This command is used for testing live migration and works for
> > +software steering only.
> > +Default FDB jump should be disabled if switchdev is enabled.
> > +The mode will propagate to all the probed ports.
> 
> Looks OK.
> 

Reply via email to