Hi, > -----Original Message----- > From: Suanming Mou <suanmi...@nvidia.com> > Sent: Wednesday, October 11, 2023 8:11 AM > To: Ferruh Yigit <ferruh.yi...@amd.com>; Ori Kam <or...@nvidia.com>; Aman > Singh <aman.deep.si...@intel.com>; Yuying Zhang <yuying.zh...@intel.com>; > NBU-Contact-Thomas Monjalon (EXTERNAL) <tho...@monjalon.net>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru> > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] ethdev: add TCP/IP modify field IDs > > Hi, > > > -----Original Message----- > > From: Ferruh Yigit <ferruh.yi...@amd.com> > > Sent: Tuesday, October 10, 2023 6:24 PM > > To: Suanming Mou <suanmi...@nvidia.com>; Ori Kam <or...@nvidia.com>; > > Aman Singh <aman.deep.si...@intel.com>; Yuying Zhang > > <yuying.zh...@intel.com>; NBU-Contact-Thomas Monjalon (EXTERNAL) > > <tho...@monjalon.net>; Andrew Rybchenko > > <andrew.rybche...@oktetlabs.ru> > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2] ethdev: add TCP/IP modify field IDs > > > > On 9/8/2023 4:49 AM, Suanming Mou wrote: > > > Currently, get TCP/IP header or data length information from traffic > > > is missing in the modify field IDs. This commit adds the missing TCP > > > data_offset, IPv4 IHL/total_len, IPv6 payload_len to modify filed IDs. > > > This allows users be able to manager more TCP/IP fields. > > > > > > Signed-off-by: Suanming Mou <suanmi...@nvidia.com> > > > --- > > > > > > v2: fix typo tcp_date_off -> tcp_data_off > > > > > > --- > > > app/test-pmd/cmdline_flow.c | 1 + > > > lib/ethdev/rte_flow.h | 4 ++++ > > > 2 files changed, 5 insertions(+) > > > > > > > Hi Suanming, > > > > Patch looks good. But, testpmd modify flow action support seems not > > documented at all, can you please first add it [1], later update that > > document with this patch? > > > > Also can you please check if `rte_flow.rst` also needs to be updated or not? > > Sure, will check and update.
`rte_flow.rst` has the modify_field action description in `Action: ``MODIFY_FIELD``` section. Will update only the ` testpmd_funcs.rst`. > Thanks > > > > > > [1]: `doc/guides/testpmd_app_ug/testpmd_funcs.rst`, `Flow rules > > management` section
