Hi Chengwen,
Ack, I will make the changes in next version of the patch.
Thanks,
Amit Shukla
> -----Original Message-----
> From: fengchengwen <fengcheng...@huawei.com>
> Sent: Monday, October 9, 2023 2:29 PM
> To: Amit Prakash Shukla <amitpraka...@marvell.com>; Kevin Laatz
> <kevin.la...@intel.com>; Bruce Richardson <bruce.richard...@intel.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> m...@smartsharesystems.com; conor.wa...@intel.com; Vamsi Krishna
> Attunuru <vattun...@marvell.com>; g.si...@nxp.com;
> sachin.sax...@oss.nxp.com; hemant.agra...@nxp.com;
> cheng1.ji...@intel.com; Nithin Kumar Dabilpuram
> <ndabilpu...@marvell.com>; Anoob Joseph <ano...@marvell.com>
> Subject: Re: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer
>
> Hi Amit,
>
> Rethink again, I suggest use auto-free to denote this feature.
>
> So we could re-define as:
> RTE_DMA_CAPA_M2D_AUTO_FREE
> RTE_DMA_OP_FLAG_AUTO_FREE
>
> struct rte_dma_auto_free_param {
> union {
> struct {
> struct rte_mempool *pool;
> } m2d;
> };
> uint64_t reserved[2]; /**< Reserved for future fields. */ }; };
> note: because one vchan only support one DMA direction, so we could use
> union.
>
> struct rte_dma_vchan_conf {
> enum rte_dma_direction direction;
> struct rte_dma_port_param src_port;
> struct rte_dma_port_param dst_port;
> struct rte_dma_auto_free_param auto_free; };
>
>
> As for later extension, if support other type auto-free, so could:
> 1. add one capa: RTE_DMA_CAPA_XXX_AUTO_FREE 2. modify
> rte_dma_auto_free_param:
> struct rte_dma_auto_free_param {
> union {
> struct {
> struct rte_mempool *pool;
> } m2d;
> struct {
> // params;
> } xxx;
> };
> uint64_t reserved[2]; /**< Reserved for future fields. */ };
> };
>
>
> Thanks.
>
<snip>
