On 10/4/23 16:51, David Marchand wrote:
- did you test with --in-memory mode? with --no-huge?
Please see v2 of the patch. I added checks for these options. They imply no multi-process support so mapping is skipped for those cases.
- I did not look at the patch, but I wonder if there is a risk some "local" ASan region (for the process heap, for example) can overlap with some "shared" ASan region (for shared DPDK hugepages).
I don't think it's possible unless the actual memory regions overlap. The ASan shadow region is always at a fixed offset from the memory it shadows. Also, this patch only makes the shadow regions shared, ASan instrumentation already uses these regions.
- with this work, would unit tests (that were marked failing with ASan) be ok now? See REGISTER_FAST_TEST macro in app/test.
I tried enabling these tests and some of them started passing with this patch, namely: - multiprocess_autotest - eal_flags_c_opt_autotest - eal_flags_main_opt_autotest - eal_flags_a_opt_autotest eal_flags_file_prefix_autotest still fails. The rest seem to be passing even without the patch. Regards, Artur
