Re: [RFC PATCH] eventdev: ensure 16-byte alignment for events

[Bruce Richardson]

On Thu, Oct 05, 2023 at 02:12:10PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Thursday, 5 October 2023 13.51
> ure 16-byte alignment for events
> > 
> > The event structure in DPDK is 16-bytes in size, and events are
> > regularly passed as parameters directly rather than being passed as
> > pointers. To help compiler optimize correctly, we can explicitly request
> > 16-byte alignment for events, which means that we should be able
> > to do aligned vector loads/stores (e.g. with SSE or Neon) when working
> > with those events.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > ---
> 
> AFAICS it is not specified anywhere that the size of this struct must be 16 
> byte.
> 
> Consider adding this requirement to the struct documentation, and possibly a 
> static_assert to verify.
> 
Yes, good point to document and verify.