> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: 21 September 2023 18:02 > To: Srikanth Yalavarthi <syalavar...@marvell.com> > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > <sshankarn...@marvell.com>; Anup Prabhu <apra...@marvell.com>; > Prince Takkar <ptak...@marvell.com>; Srikanth Yalavarthi > <syalavar...@marvell.com> > Subject: [EXT] Re: [PATCH v1 19/34] ml/cnxk: support config and close of > tvmdp library > > External Email > > ---------------------------------------------------------------------- > On Wed, Aug 30, 2023 at 9:34 PM Srikanth Yalavarthi > <syalavar...@marvell.com> wrote: > > > > Added support to configure and close TVMDP library based on ML device > > configuration options. > > > > Updated meson build to enable Jansson, TVM runtime, TVMDP library as > > build dependencies. > > If it is optional – please add optional > > please update cnxk ml driver documentation on this dependency and > example command to build it. See DPDK mlx5 docs for dependency > documentation.
Updated the driver documentation with details related to external libraries in v3 patch series. > > > > > > Signed-off-by: Srikanth Yalavarthi <syalavar...@marvell.com> > > --- > > drivers/ml/cnxk/cnxk_ml_ops.c | 15 ++++++++++++ > > drivers/ml/cnxk/meson.build | 45 > ++++++++++++++++++++++++++++++++++ > > drivers/ml/cnxk/mvtvm_ml_ops.c | 44 > +++++++++++++++++++++++++++++++++ > > drivers/ml/cnxk/mvtvm_ml_ops.h | 15 ++++++++++++ > > 4 files changed, 119 insertions(+) > > create mode 100644 drivers/ml/cnxk/mvtvm_ml_ops.c create mode > 100644 > > drivers/ml/cnxk/mvtvm_ml_ops.h > > > > diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c > > b/drivers/ml/cnxk/cnxk_ml_ops.c index b2eb4bd0d9a..454fec33234 > 100644 > > --- a/drivers/ml/cnxk/cnxk_ml_ops.c > > +++ b/drivers/ml/cnxk/cnxk_ml_ops.c > > @@ -9,6 +9,10 @@ > > > > #include "cn10k_ml_ops.h" > > > > +#ifdef RTE_MLDEV_CNXK_ENABLE_MVTVM > > +#include "mvtvm_ml_ops.h" > > +#endif > > + > > #include "cnxk_ml_dev.h" > > #include "cnxk_ml_io.h" > > #include "cnxk_ml_model.h" > > @@ -625,6 +629,12 @@ cnxk_ml_dev_configure(struct rte_ml_dev *dev, > const struct rte_ml_dev_config *co > > goto error; > > } > > > > +#ifdef RTE_MLDEV_CNXK_ENABLE_MVTVM > > If this #ifdef used a lot place in code like this, Please have stub and > segregate > at once place in header file and avoid ifdef main code like > cnxk_ml_dev_configure(). Reorganized the code to reduce the use of RTE_MLDEV_CNXK_ENABLE_MVTVM. Changes part of v3 series.
