> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 11 August 2023 21.21 > > Use standard ternary operator instead of gcc extension. There is > no concern of side-effects for this evaluation so allow the code > to be portable. > > While here update the condition to compare default_log_stream > directly against NULL. > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > --- > lib/log/log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/log/log.c b/lib/log/log.c > index 52c771f..b80725a 100644 > --- a/lib/log/log.c > +++ b/lib/log/log.c > @@ -93,7 +93,7 @@ struct log_cur_msg { > * of stderr, even if the application closes and > * reopens it. > */ > - return default_log_stream ? : stderr;
I didn't know this GCC extension. Someone please consider disallowing this in checkpatches. > + return default_log_stream != NULL ? default_log_stream : stderr; > } > return f; > } > -- > 1.8.3.1 Reviewed-by: Morten Brørup <m...@smartsharesystems.com>
