On 2023/9/13 19:48, Pattan, Reshma wrote:
-----Original Message----- From: Jie Hai <haij...@huawei.com> Sent: Friday, September 8, 2023 9:00 AM To: dev@dpdk.org; Pattan, Reshma <reshma.pat...@intel.com>; Vipin Varghese <vipin.vargh...@amd.com>; Mcnamara, John <john.mcnam...@intel.com> Cc: haij...@huawei.com; lihuis...@huawei.com Subject: [PATCH v4 4/7] app/proc-info: fix never show RSS info Command show-port should show RSS info (rss_key, len and rss_hf), However, the information is shown only when rss_conf.rss_key is not NULL. Since no memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the rss_info will never show. This patch allocates memory for rss_conf.rss_key and makes it possible to show RSS info.
Hi, Pattan, Reshma
Nitpick: You have to change the commit message as malloc and free not used now. Acked-by: Reshma Pattan <reshma.pat...@intel.com>
Thanks for your comment, will do in next version. Best regards, Jie Hai
.