On Thu, Sep 21, 2023 at 11:36:32AM +0200, Thomas Monjalon wrote: > 01/09/2023 01:08, Tyler Retzlaff: > > On Thu, Aug 31, 2023 at 01:57:36PM +0200, Thomas Monjalon wrote: > > > 11/07/2023 17:52, Tyler Retzlaff: > > > > +#ifdef RTE_TOOLCHAIN_MSVC > > > > /** > > > > * Macro to define a per lcore variable "var" of type "type", don't > > > > * use keywords like "static" or "volatile" in type, just prefix the > > > > * whole macro. > > > > */ > > > > #define RTE_DEFINE_PER_LCORE(type, name) \ > > > > - __thread __typeof__(type) per_lcore_##name > > > > + __declspec(thread) typeof(type) per_lcore_##name > > > > > > > > /** > > > > * Macro to declare an extern per lcore variable "var" of type "type" > > > > */ > > > > #define RTE_DECLARE_PER_LCORE(type, name) \ > > > > + extern __declspec(thread) typeof(type) per_lcore_##name > > > > +#else > > > > +#define RTE_DEFINE_PER_LCORE(type, name) \ > > > > + __thread __typeof__(type) per_lcore_##name > > > > + > > > > +#define RTE_DECLARE_PER_LCORE(type, name) \ > > > > extern __thread __typeof__(type) per_lcore_##name > > > > +#endif > > > > > > I'm afraid you damaged the doxygen document here. > > > Please check what happens when generating doxygen. > > > I suppose it does not take the RTE_TOOLCHAIN_MSVC path, > > > so it does not find any comment. > > > > Thanks Thomas i will look into fixing it. > > Please can you send the fix? >
Sure, do you want me to just move the documentation to the non MSVC path or do you have another prefered solution in mind?
