> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, September 15, 2015 2:11 PM > To: Horton, Remy > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH v1] rte: LCore heartbeat example > > Hi, > > 2015-09-15 13:16, Remy Horton: > > Provides a basic framework for detecting and reporting live-ness of > > LCores, the primary requirement of which is minimal overheads for the > > core(s) being checked. Core failures are notified via an application > > defined callback. As an example l2fwd with random failures is used. > > ... > Please try to use an existing example instead of creating a new one.
Hi, I don't know if this is a good general rule. If the feature is distinct then a new sample application is appropriate. Grouping too much functionality into a single sample app makes them less useful as reference implementations of different DPDK functionality. The l2fwd application, for example, has become cluttered with different functionality. John. --