On Tue, Sep 19, 2023 at 10:29:07AM +0200, David Marchand wrote: > On Fri, Sep 15, 2023 at 1:52 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > To help ensure that we don't have "orphaned" tests not in any test > > suites we can add the following checks: > > > > * In developer-mode builds, emit a warning for each test defined using > > REGISTER_TEST_COMMAND > > * In checkpatches, add a check to prevent the addition of new tests > > using the REGISTER_TEST_COMMAND macro > > > > Bruce Richardson (2): > > app/test: emit warning for tests not in a test suite > > devtools: check for tests added without a test suite > > > > app/test/suites/meson.build | 13 ++++++++++++- > > buildtools/get-test-suites.py | 12 +++++++++--- > > devtools/checkpatches.sh | 8 ++++++++ > > 3 files changed, 29 insertions(+), 4 deletions(-) > > The "non_suite_tests" testsuite returned by > buildtools/get-test-suites.py is a bit strange, as it is not a > testsuite from meson pov.
Yeah, it is a bit strange, and I'm open to new ideas on other solutions. I did it that way to avoid having yet another script to scan the files - I figured it was faster (in terms of runtime, not dev time) to do the scanning when the files are already being opened and processed by this one. Of course, if we can get the un-suitened [:-)] test cases down to zero, we can theoretically drop this check in future, and just use the checkpatch one. /Bruce
