Hi Arek, > -----Original Message----- > From: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com> > Sent: Sunday, September 17, 2023 4:43 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai <kai...@intel.com>; Power, Ciara > <ciara.po...@intel.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusz...@intel.com> > Subject: [PATCH 2/3] common/qat: move command line params to the device > struct > > Command line parameters was moved to the device struct. > > Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusz...@intel.com> > --- > drivers/common/qat/qat_device.c | 54 ++++++++++++++++++-------------- > ----- > drivers/common/qat/qat_device.h | 35 ++++++++++++------------ > drivers/compress/qat/qat_comp_pmd.c | 9 +++---- > drivers/compress/qat/qat_comp_pmd.h | 3 +-- > drivers/crypto/qat/qat_asym.c | 13 +++++---- > drivers/crypto/qat/qat_sym.c | 23 ++++++++-------- > 6 files changed, 66 insertions(+), 71 deletions(-) > > diff --git a/drivers/common/qat/qat_device.c > b/drivers/common/qat/qat_device.c index 93aef9aeb1..d9604e666d > 100644 > --- a/drivers/common/qat/qat_device.c > +++ b/drivers/common/qat/qat_device.c > @@ -22,6 +22,16 @@ <snip> > diff --git a/drivers/common/qat/qat_device.h > b/drivers/common/qat/qat_device.h index 23d7f54b61..dcb5a42c89 > 100644 > --- a/drivers/common/qat/qat_device.h > +++ b/drivers/common/qat/qat_device.h > @@ -17,14 +17,21 @@ > > #define QAT_DEV_NAME_MAX_LEN 64 > > -#define QAT_LEGACY_CAPA "qat_legacy_capa" > +#define QAT_LEGACY_CAPA_NAME "qat_legacy_capa" > #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold" > #define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold" > #define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold" > #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable" > -#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable" > -#define QAT_CMD_SLICE_MAP_POS 5 > -#define MAX_QP_THRESHOLD_SIZE 32 > +#define QAT_CMD_SLICE_MAP_NAME "qat_cmd_slice_disable" > +#define QAT_LEGACY_CAPA_POS 0 > +#define SYM_ENQ_THRESHOLD_POS 1 > +#define ASYM_ENQ_THRESHOLD_POS 2 > +#define COMP_ENQ_THRESHOLD_POS 3 > +#define SYM_CIPHER_CRC_ENABLE_POS 4 > +#define QAT_CMD_SLICE_MAP_POS 5
Small suggestion, maybe an enum could be used to group the above position macros together. Acked-by: Ciara Power <ciara.po...@intel.com>
