Conditional check is not necessary to strip and get status bits
from the descriptor.

Signed-off-by: Pavan Kumar Linga <pavan.kumar.li...@intel.com>
Signed-off-by: Simei Su <simei...@intel.com>
Acked-by: Beilei Xing <beilei.x...@intel.com>
---
 drivers/common/idpf/base/idpf_controlq.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/common/idpf/base/idpf_controlq.c 
b/drivers/common/idpf/base/idpf_controlq.c
index 7b12dfab18..da5c930578 100644
--- a/drivers/common/idpf/base/idpf_controlq.c
+++ b/drivers/common/idpf/base/idpf_controlq.c
@@ -426,11 +426,8 @@ static int __idpf_ctlq_clean_sq(struct idpf_ctlq_info *cq, 
u16 *clean_count,
                if (!force && !(LE16_TO_CPU(desc->flags) & IDPF_CTLQ_FLAG_DD))
                        break;
 
-               desc_err = LE16_TO_CPU(desc->ret_val);
-               if (desc_err) {
-                       /* strip off FW internal code */
-                       desc_err &= 0xff;
-               }
+               /* strip off FW internal code */
+               desc_err = LE16_TO_CPU(desc->ret_val) & 0xff;
 
                msg_status[i] = cq->bi.tx_msg[ntc];
                if (!msg_status[i])
-- 
2.25.1

Reply via email to