Recheck-request: iol-unit-arm64-testing, iol-intel-Performance

On Fri, Sep 01, 2023 at 03:23:31PM +0100, Bruce Richardson wrote:
> When the user passes a list of desired libraries to build via the
> "enable_libs" option, the expectation is that those libraries should be
> part of the build. However, if those libs have either external or
> internal dependencies, they still may be silently disabled, for example:
> running "meson setup -Denable_libs=security build" will successfully
> run, but the security lib will not be configured as "cryptodev" is
> missing.
> 
> We can fix this by setting a flag to indicate when the libraries are
> specified via an enable_libs flag. If so, then we error out when a
> library is unbuildable, giving a suitable error message. For the above
> example case, the "meson setup" run fails with:
> 
> Message: Disabling security [lib/security]: missing internal dependency 
> "cryptodev"
> 
> lib/meson.build:218:16: ERROR: Problem encountered: Cannot build explicitly 
> requested lib "security".
>       Please add missing dependency "cryptodev" to "enable_libs" option
> 
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
>  lib/meson.build | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Reply via email to