On Fri, 8 Sep 2023 17:28:08 +0800 Jie Hai <haij...@huawei.com> wrote:
> Hi, Stephen Hemminger > > On 2023/9/6 23:10, Stephen Hemminger wrote: > > On Sat, 26 Aug 2023 15:46:03 +0800 > > Jie Hai <haij...@huawei.com> wrote: > > > >> Currently, rte_eth_rss_conf supports configuring and querying > >> rss hash functions, rss key and it's length, but not rss hash > >> algorithm. > >> > >> The structure ``rte_eth_rss_conf`` is extended by adding a new > >> field "func". This represents the RSS algorithms to apply. The > >> following API is affected: > >> - rte_eth_dev_configure > >> - rte_eth_dev_rss_hash_update > >> - rte_eth_dev_rss_hash_conf_get > >> > >> If the value of "func" used for configuration is a gibberish > >> value, report the error and return. Do the same for > >> rte_eth_dev_rss_hash_update and rte_eth_dev_configure. > >> > >> To check whether the drivers report the "func" field, it is set > >> to default value before querying. > >> > >> Signed-off-by: Jie Hai <haij...@huawei.com> > >> Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> > > > > This is unannounced API/ABI change. > Thanks for pointing that. I'm sorry I didn't pay attention to this before. > What should I do with this set of patches? > Is it feasible to send annouce now? Since this API/ABI breaking release, I am ok taking it. But will need a release note. Also you should treat 0 as "no change" case to allow for code that does hash_update without setting the value.
