On Thu, 31 Aug 2023 19:19:37 +0800
Fengnan Chang <changfeng...@bytedance.com> wrote:
> +#ifndef RTE_MALLOC_DEBUG
> + if (internal_conf->legacy_mem) {
> + /* If orig_elem is dirty, the joint element is clean, we need
> do memset now */
> + if (elem->orig_elem->dirty && !elem->dirty)
> + memset(ptr, 0, data_len);
> + } else if (!elem->dirty) {
> + memset(ptr, 0, data_len);
> + }
> +#else
> + /* Always poison the memory in debug mode. */
> + memset(ptr, MALLOC_POISON, data_len);
> +#endif
The code reads better if positive clause was first.
I.e.
#ifdef RTE_MALLOC_DEBUG
/* Always poison the memory in debug mode. */
memset(ptr, MALLOC_POISON, data_len);
#else
...
