On Fri, Aug 25, 2023 at 8:18 PM Morten Brørup <m...@smartsharesystems.com> wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 25 August 2023 19.03 > > > > A few classes meson.build were not expressing dependencies to the > > associated device library. Define std_deps for baseband, gpu and regex > > drivers. > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > On the surface, it looks like you are also removing a lot of (superfluous) > dependencies. If not just a side effect of the added std_deps, perhaps the > patch description should mention this too.
The dependency to the device library in a driver become superfluous as a result of adding it to std_deps: - std_deps is passed to drivers as the default deps: https://git.dpdk.org/dpdk/tree/drivers/meson.build#n125 - none of those updated drivers meson.build was overriding/resetting deps (grep -w deps $patch). I'll add a note in the commitlog to make this explicit. > > Anyway, > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > Thanks. -- David Marchand
