> -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, August 22, 2023 3:59 PM > To: 'David Marchand' <david.march...@redhat.com> > Cc: dev@dpdk.org; echau...@redhat.com; m...@redhat.com; > sta...@dpdk.org; Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei > <beilei.x...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>; Sinha, > Abhijit <abhijit.si...@intel.com>; Nicolau, Radu <radu.nico...@intel.com> > Subject: RE: [PATCH] net/iavf: fix checksum offloading > > > > > -----Original Message----- > > From: David Marchand <david.march...@redhat.com> > > Sent: Tuesday, August 22, 2023 3:40 PM > > To: Zhang, Qi Z <qi.z.zh...@intel.com> > > Cc: dev@dpdk.org; echau...@redhat.com; m...@redhat.com; > > sta...@dpdk.org; Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei > > <beilei.x...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>; > > Sinha, Abhijit <abhijit.si...@intel.com>; Nicolau, Radu > > <radu.nico...@intel.com> > > Subject: Re: [PATCH] net/iavf: fix checksum offloading > > > > On Tue, Aug 22, 2023 at 9:33 AM Zhang, Qi Z <qi.z.zh...@intel.com> wrote: > > > > If the driver reads l2_len or l3_len, this is an undefined behavior: > > > > for example, OVS might have been using l2_len or l3_len for its > > > > internal uses (though I agree it would be risky for an application to > > > > do so). > > > > > > > > We probably need to fix access to l2_len a few lines before my patch. > > > > > > > > if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK && > > > > !(m->ol_flags & RTE_MBUF_F_TX_SEC_OFFLOAD)) > > > > offset |= (m->outer_l2_len >> 1) > > > > << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT; > > > > else > > > > offset |= (m->l2_len >> 1) > > > > << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT; > > > >
After second thought, I think your patch looks good, will you submit a new version to cover above fix?
