> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: Monday, August 21, 2023 9:07 PM > To: Naga Harish K, S V <s.v.naga.haris...@intel.com> > Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carri...@intel.com>; Gujjar, > Abhinandan S <abhinandan.guj...@intel.com>; McDaniel, Timothy > <timothy.mcdan...@intel.com>; pbhagavat...@marvell.com; > sthot...@marvell.com; hemant.agra...@nxp.com; > sachin.sax...@oss.nxp.com; Van Haaren, Harry > <harry.van.haa...@intel.com>; mattias.ronnblom > <mattias.ronnb...@ericsson.com>; lian...@liangbit.com; Mccarthy, Peter > <peter.mccar...@intel.com>; Jayatheerthan, Jay > <jay.jayatheert...@intel.com> > Subject: Re: [PATCH v6] eventdev/eth_rx: add new adapter create API > > On Mon, Aug 21, 2023 at 8:59 PM Naga Harish K S V > <s.v.naga.haris...@intel.com> wrote: > > > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > > creating Rx adapter instance. This API is similar to > > rte_event_eth_rx_adapter_create_ext() with an additional input > > argument for adapter configuration parameters of type "struct > > rte_event_eth_rx_adapter_params". > > > > Signed-off-by: Naga Harish K S V <s.v.naga.haris...@intel.com> > > --- > > v2: > > * Fix warning > > v3: > > * remove __rte_cold hint as per review comments > > v4: > > * address review comments > > v5: > > * Update release notes document > > v6: > > * incorporate review comments > > > +static int __rte_cold > > Missed again to remove _rte_cold. > Seriously, Please pay some attention when sending the patch(Same comment > given in last time). > __rte_cold is already removed for API definition and prototype. I thought having __rte_cold for this internal function is fine. It is removed in the latest patch, thanks.
> > > +rxa_config_params_validate(struct rte_event_eth_rx_adapter_params > *rxa_params, > > + struct rte_event_eth_rx_adapter_params > > +*temp_params)
