On Thu, Aug 10, 2023 at 06:31:56PM -0700, Tyler Retzlaff wrote:
> Provide API for atomic operations in the rte namespace that may
> optionally be configured to use C11 atomics with meson
> option enable_stdatomics=true
> 
> Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
> ---
>  config/meson.build              |   1 +
>  config/rte_config.h             |   1 +
>  lib/eal/include/meson.build     |   1 +
>  lib/eal/include/rte_stdatomic.h | 162 
> ++++++++++++++++++++++++++++++++++++++++
>  meson_options.txt               |   1 +
>  5 files changed, 166 insertions(+)
>  create mode 100644 lib/eal/include/rte_stdatomic.h
> 
<snip>
> diff --git a/meson_options.txt b/meson_options.txt
> index 621e1ca..7d6784d 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -46,6 +46,7 @@ option('mbuf_refcnt_atomic', type: 'boolean', value: true, 
> description:
>         'Atomically access the mbuf refcnt.')
>  option('platform', type: 'string', value: 'native', description:
>         'Platform to build, either "native", "generic" or a SoC. Please refer 
> to the Linux build guide for more information.')
> +option('enable_stdatomic', type: 'boolean', value: false, description: 
> 'enable use of C11 stdatomic')

Minor nit - all other options in this file put the description on it's own
line. For consistency I think we should do the same here.

>  option('enable_trace_fp', type: 'boolean', value: false, description:
>         'enable fast path trace points.')
>  option('tests', type: 'boolean', value: true, description:
> -- 
> 1.8.3.1
> 

Reply via email to