Hi, > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yu Nemo Wenbin > Sent: Friday, November 27, 2015 2:11 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function. > > Give user a chance to customize the hash key compare function. > The default rte_hash_cmp_eq function is set in the rte_hash_create > function, but these builtin ones may not be good enough, so the user > may call this to override the default one. > > Signed-off-by: Yu Nemo Wenbin <yuwb_bjy at ctbri.com.cn> > --- > lib/librte_hash/rte_cuckoo_hash.c | 7 +++++-- > lib/librte_hash/rte_hash.h | 15 +++++++++++++++ > lib/librte_hash/rte_hash_version.map | 7 +++++++ > 3 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_hash/rte_cuckoo_hash.c > b/lib/librte_hash/rte_cuckoo_hash.c > index 88f77c3..2ccb81c 100644 > --- a/lib/librte_hash/rte_cuckoo_hash.c > +++ b/lib/librte_hash/rte_cuckoo_hash.c > @@ -102,8 +102,6 @@ EAL_REGISTER_TAILQ(rte_hash_tailq) > > #define LCORE_CACHE_SIZE 8 > > -typedef int (*rte_hash_cmp_eq_t)(const void *key1, const void *key2, > size_t key_len); > - > struct lcore_cache { > unsigned len; /**< Cache len */ > void *objs[LCORE_CACHE_SIZE]; /**< Cache objects */ > @@ -187,6 +185,11 @@ rte_hash_find_existing(const char *name) > return h; > } > > +void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t > func) > +{ > + h->rte_hash_cmp_eq = func; > +} > + > struct rte_hash * > rte_hash_create(const struct rte_hash_parameters *params) > { > diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h > index b678766..dfca5ef 100644 > --- a/lib/librte_hash/rte_hash.h > +++ b/lib/librte_hash/rte_hash.h > @@ -66,6 +66,9 @@ typedef uint32_t hash_sig_t; > typedef uint32_t (*rte_hash_function)(const void *key, uint32_t key_len, > uint32_t init_val); > > +/** Type of function used to compare the hash key. */ > +typedef int (*rte_hash_cmp_eq_t)(const void *key1, const void *key2, > size_t key_len); > + > /** > * Parameters used when creating the hash table. > */ > @@ -104,6 +107,18 @@ struct rte_hash * > rte_hash_create(const struct rte_hash_parameters *params); > > /** > + * Set the rte_hash_set_cmp_func. > + * Set a new hash compare function other than the default one. > + * > + * @note Function pointer does not work with multi-process, so don't use > it > + * in multi-process mode. > + * > + * @param h > + * Hash table to reset > + */ > +void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t > func); > + > +/** > * Find an existing hash table object and return a pointer to it. > * > * @param name > diff --git a/lib/librte_hash/rte_hash_version.map > b/lib/librte_hash/rte_hash_version.map > index 906c8ad..1aa94f9 100644 > --- a/lib/librte_hash/rte_hash_version.map > +++ b/lib/librte_hash/rte_hash_version.map > @@ -32,3 +32,10 @@ DPDK_2.1 { > rte_hash_reset; > > } DPDK_2.0; > + > +DPDK_2.2 { > + global: > + > + rte_hash_set_cmp_func; > + > +} DPDK_2.1; > -- > 1.9.1
Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com> Although, you needed to send this as a v2 (or v3?)!
