On 11/26/15 22:35, Thomas Monjalon wrote: > When introducing LRO, Vlad has defined the macro RTE_ETHDEV_HAS_LRO_SUPPORT: > http://dpdk.org/browse/dpdk/commit/lib/librte_ether/rte_ethdev.h?id=8eecb329 > > It allows to use the feature without version check (before the release or > after a backport). > Do you think it is useful? > Should we define other macros RTE_[API]_HAS_[FEATURE] for each new feature > or API change?
The main purpose of the above macro was to identify the presence of the new field in the rte_eth_rxmode during the period of time when there was no other way to know it. Once this may be concluded based on the release version I see no reason to keep it. > It's time to fix it before releasing the 2.2 version.
