06/06/2023 18:35, Stephen Hemminger: > On Tue, 6 Jun 2023 16:50:53 +0100 > Ferruh Yigit <ferruh.yi...@amd.com> wrote: > > > On 6/6/2023 4:39 PM, Stephen Hemminger wrote: > > > On Tue, 6 Jun 2023 20:11:26 +0800 > > > Dongdong Liu <liudongdo...@huawei.com> wrote: > > > > > >> Deprecation notice to add "func" field to ``rte_eth_rss_conf`` > > >> structure for RSS hash algorithm. > > >> > > >> Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> > > >> --- > > > > > > New fields do not require deprecation notice. > > > Since this seems to be a repeated issue, perhaps someone should > > > add this to the documentation.
I've just sent such a patch: https://patches.dpdk.org/project/dpdk/patch/20230728142946.1201459-1-tho...@monjalon.net/ > > Hi Stephen, > > > > This is follow up to an existing patchset: > > https://patches.dpdk.org/project/dpdk/list/?series=27400&state=* > > > > Although field is addition to the "struct rte_eth_rss_conf" struct, it > > is embedded into "struct rte_eth_conf" which is parameter to an API, so > > change cause size increase in outer struct and causes ABI breakage, > > requiring deprecation notice. > > It will change ABI so will have to wait for 23.11. > But the purpose of deprecation notice is more about telling users that API > will change. > > The automated tools may give false complaint. Ok to add to deprecation, > but really not necessary. This deprecation notice is marked as superseded, given my patch above should be enough.
