On Tue, Mar 14, 2023 at 10:18:58AM -0700, Stephen Hemminger wrote:
> Function was added by commit 067855e651d6 ("cmdline: add polling mode")
> but never tested or used by DPDK applications. Mark it for
> future removal.
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 872847e938ed..28c458591a68 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -135,3 +135,8 @@ Deprecation Notices
> Its removal has been postponed to let potential users report interest
> in maintaining it.
> In the absence of such interest, this library will be removed in DPDK
> 23.11.
> +
> +* cmdline: The function ``cmdline_poll`` does not work correctly on either
> + Linux or Windows and is unused by any part of DPDK.
> + It will be marked deprecated
> + starting in the 23.07 relead and removed in DPDK 23.11.
typo: "release".
We also should ack a "deprecated" tag on the function to give build-time
warnings. Since we are in the middle of having patches merged, I'll spin a
v2 for you to save time.
> --
> 2.39.2
>
