On Tue, Jul 11, 2023 at 10:12:02AM +0100, Ferruh Yigit wrote: > On 7/6/2023 3:42 AM, Stephen Hemminger wrote: > > On Wed, 5 Jul 2023 19:32:48 -0700 > > Stephen Hemminger <step...@networkplumber.org> wrote: > > > >> The mailmap file is supposed to be in sorted order, > >> but several entries are in the wrong place. > >> > >> Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > >> --- > >> v2 - use en_us.UTF-8 sort order > >> > >> .mailmap | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/.mailmap b/.mailmap > >> index d200f363394d..bfd3528cf734 100644 > >> --- a/.mailmap > >> +++ b/.mailmap > >> @@ -115,8 +115,8 @@ Anoob Joseph <ano...@marvell.com> > >> <anoob.jos...@caviumnetworks.com> > >> Antara Ganesh Kolar <antara.ganesh.ko...@intel.com> > >> Anthony Fee <anthonyx....@intel.com> > >> Antonio Fischetti <antonio.fische...@intel.com> > >> -Anup Prabhu <apra...@marvell.com> > >> Anupam Kapoor <anupam.kap...@gmail.com> > >> +Anup Prabhu <apra...@marvell.com> > >> Apeksha Gupta <apeksha.gu...@nxp.com> > >> Archana Muniganti <march...@marvell.com> > >> <muniganti.arch...@caviumnetworks.com> > >> Archit Pandey <architpandeyn...@gmail.com> > > > > Never mind, something is off if Anup shows up after Anupam > > > > This sorting logic already in the file: > Yanjie Xu <yanjie...@intel.com> > Yan Xia <yanx....@intel.com> > > and I don't know how to take following (may sort be ignoring the > white-space between name and surname?): > Yi Li <li...@chinatelecom.cn> > Yi Liu <yi....@nxp.com> > Yilong Lv <lvyilong....@alibaba-inc.com> > Yi Lu <luy...@live.com> > > > But to be able to sort whole file with 'sort' and no need to manually > fix above quirks, I am OK with the change, hence: > > Acked-by: Ferruh Yigit <ferruh.yi...@amd.com>
It's a good first step, but I tend to agree with Stephen that having Yan appear after Yanjie indicates incorrect sorting. Testing with "sort" on my system, "sort -f" [or "sort --ignore-case"] seems to do the right thing. The capital letter on the second names in the list may be throwing things off. /Bruce
