On Thu, 26 Nov 2015 09:49:21 +0000 Alejandro Lucero <alejandro.lucero at netronome.com> wrote:
> +static inline void > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > +{ > + uint32_t off; Minor nit. why mix use of Linux specific basic size typedefs (__u8) with Posix standard values (uint32_t). The DPDK style is to use the Posix types except in kernel drivers or code that is coming from unified drivers (ie ixgbe/base)