On 7/8/2023 2:52 AM, Stephen Hemminger wrote: > On Fri, 7 Jul 2023 20:43:51 +0000 > Long Li <lon...@microsoft.com> wrote: > >>> Subject: Re: [PATCH] net/netvsc: set the correct queue state >>> >>> On Fri, 7 Jul 2023 11:53:16 -0700 >>> lon...@linuxonhyperv.com wrote: >>> >>>> From: Long Li <lon...@microsoft.com> >>>> >>>> Set the queue state when queue is started/stopped. >>>> >>>> Signed-off-by: Long Li <lon...@microsoft.com> >>>> --- >>>> drivers/net/netvsc/hn_ethdev.c | 15 ++++++++++++++- >>>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> Interesting that not all drivers do this. >>> >>> Acked-by: Stephen Hemminger <step...@networkplumber.org> >>> >>> The ones not doing it. >>> af_packet >>> af_xdp >>> avp >>> axgbe >>> bnx2x >>> bonding >>> dpaa >>> dpaa2 >>> e1000 >>> ena >>> enetfec >>> gve >>> hinic >>> igc >>> ipn3ke >>> kni >>> liquidio >>> mana >>> memif >>> mlx4 >>> netvsc >>> nfp >>> null >>> octeon_ep >>> pfe >>> ring >>> softnic >>> vdev_netvsc >>> vhost >>> virtio >>> vmxnet3 >> >> Testpmd added the check for stopped queues: >> 3c4426db54 app/testpmd: do not poll stopped queues >> >> To pass testpmd, PMD needs to set queue state. > > So there are 20 drivers broken by that change! > Sounds like it needs to be reverted. >
testpmd change is already reverted in the next-net, but planned to merge it back in next release, and we need driver changes in next release.
