On Thu, Jun 29, 2023 at 4:27 AM Miao Li <miao...@intel.com> wrote:
>
> When doing IO port map for legacy device in secondary process,
> vfio_cfg setup for legacy device like vfio_group_fd and vfio_dev_fd
> is missing. So, in secondary process, rte_pci_map_device is added
> for legacy device to setup vfio_cfg and fill in region info like in
> primary process.
I think, in legacy mode, there is no PCI mappable memory.
So there should be no need for this call to rte_pci_map_device.
What is missing is a vfio setup, is this correct?
I'd rather see this issue be fixed in the pci_vfio_ioport_map() function.
>> Fixes: 512e27eeb743 ("net/virtio: move PCI specific dev init to PCI ethdev
>> init")
This commit only moved code, and at this point, there was no need for
a call to rte_pci_map_device in the secondary process case.
It seems unlikely this is a faulty change.
The recent addition on the vfio side seems a better culprit, but I am
fine with being proven wrong :-).
> Cc: sta...@dpdk.org
>
> Signed-off-by: Miao Li <miao...@intel.com>
--
David Marchand
