Hi David, David Young <d...@youngcopy.com> writes:
> --- Thanks for the contribution! Very happy to have someone working on the docs. Thanks for getting a patch to the mailing list. Just a few nits to address before the patch can get merged. Customarily, a change to each area will describe that in the subject - ie: docs: freebsd: Update to 20.11 Then in the message body, we can add a bit extra detailing why the change was needed: The docs were specifying to install the dpdk package, but this is ambiguous/didn't work/blah blah blah... Finally, just before the end, we add a DCO sign-off tag: Signed-off-by: David Young <d...@youngcopy.com> When replying for a v2, v3, etc., you will need to reply to the most recent version which was obsoleted (in this case, git send-email \ --in-reply-to="<20230629181209.400-1-d...@youngcopy.com>") and make sure that the [PATCH] metadata line includes the text v2. Thanks! > doc/guides/freebsd_gsg/install_from_ports.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/freebsd_gsg/install_from_ports.rst > b/doc/guides/freebsd_gsg/install_from_ports.rst > index d946f3f3b2..ae866cd879 100644 > --- a/doc/guides/freebsd_gsg/install_from_ports.rst > +++ b/doc/guides/freebsd_gsg/install_from_ports.rst > @@ -23,7 +23,7 @@ Installing the DPDK Package for FreeBSD > > DPDK can be installed on FreeBSD using the command:: > > - pkg install dpdk > + pkg install dpdk20.11 > > After the installation of the DPDK package, instructions will be printed on > how to install the kernel modules required to use the DPDK. A more > @@ -51,7 +51,7 @@ a pre-compiled binary package. > On a system with the ports collection installed in ``/usr/ports``, the DPDK > can be installed using the commands:: > > - cd /usr/ports/net/dpdk > + cd /usr/ports/net/dpdk20.11 > > make install > > @@ -123,3 +123,4 @@ via the contigmem module, and 4 NIC ports bound to the > nic_uio module:: > > For an explanation of the command-line parameters that can be passed to an > DPDK application, see section :ref:`running_sample_app`. > +
