[PATCH v4 2/5] eal: turn off getopt_long error message during eal_log_level

[Stephen Hemminger]

If DPDK application is given a bogus option, the error message
would get printed twice. Once during scan for log level and
again during parsing of arguments.

Example:
        # ./build/app/dpdk-testpmd --bogus
        ./build/app/dpdk-testpmd: unrecognized option '--bogus'
        EAL: Detected CPU lcores: 16
        EAL: Detected NUMA nodes: 1
        ./build/app/dpdk-testpmd: unrecognized option '--bogus'

        Usage: ./build/app/dpdk-testpmd [options]

Fix by suppressing printing error message on first pass.

Signed-off-by: Keith Wiles <keith.wi...@intel.com>
Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 lib/eal/freebsd/eal.c | 2 ++
 lib/eal/linux/eal.c   | 2 ++
 lib/eal/windows/eal.c | 3 +++
 3 files changed, 7 insertions(+)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 6df6873e3889..70087837da18 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -381,6 +381,7 @@ eal_log_level_parse(int argc, char **argv)
        argvopt = argv;
        optind = 1;
        optreset = 1;
+       opterr = 0;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                                  eal_long_options, &option_index)) != EOF) {
@@ -424,6 +425,7 @@ eal_parse_args(int argc, char **argv)
        argvopt = argv;
        optind = 1;
        optreset = 1;
+       opterr = 1;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                                  eal_long_options, &option_index)) != EOF) {
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 145afafde234..60bb130aea15 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -561,6 +561,7 @@ eal_log_level_parse(int argc, char **argv)
 
        argvopt = argv;
        optind = 1;
+       opterr = 0;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                                  eal_long_options, &option_index)) != EOF) {
@@ -638,6 +639,7 @@ eal_parse_args(int argc, char **argv)
 
        argvopt = argv;
        optind = 1;
+       opterr = 1;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                                  eal_long_options, &option_index)) != EOF) {
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 2d7a0e9ab27e..0800a9e5c2d2 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -106,6 +106,8 @@ eal_log_level_parse(int argc, char **argv)
        struct internal_config *internal_conf =
                eal_get_internal_configuration();
 
+       opterr = 0;
+
        argvopt = argv;
 
        eal_reset_internal_config(internal_conf);
@@ -143,6 +145,7 @@ eal_parse_args(int argc, char **argv)
                eal_get_internal_configuration();
 
        argvopt = argv;
+       opterr = 1;
 
        while ((opt = getopt_long(argc, argvopt, eal_short_options,
                eal_long_options, &option_index)) != EOF) {
-- 
2.39.2