> -----Original Message----- > From: Slava Ovsiienko <[email protected]> > Sent: Tuesday, June 20, 2023 7:44 PM > > > -----Original Message----- > > From: David Marchand <[email protected]> > > Sent: Tuesday, June 20, 2023 2:10 PM > > To: [email protected] > > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; > > [email protected]; Ali Alnubani <[email protected]>; Aman Singh > > <[email protected]>; Yuying Zhang <[email protected]>; > > Matan Azrad <[email protected]>; Slava Ovsiienko > > <[email protected]>; Ori Kam <[email protected]>; Suanming Mou > > <[email protected]>; David Christensen <[email protected]>; > > Ruifeng Wang <[email protected]>; Bruce Richardson > > <[email protected]>; Konstantin Ananyev > > <[email protected]>; Andrew Rybchenko > > <[email protected]>; Ferruh Yigit <[email protected]> > > Subject: [RFC PATCH v3] ethdev: advertise flow restore in mbuf > > > > As reported by Ilya [1], unconditionally calling > > rte_flow_get_restore_info() impacts an application performance for drivers > > that do not provide this ops. > > It could also impact processing of packets that require no call to > > rte_flow_get_restore_info() at all. > > > > Register a dynamic mbuf flag when an application negotiates tunnel > metadata > > delivery (calling rte_eth_rx_metadata_negotiate() with > > RTE_ETH_RX_METADATA_TUNNEL_ID). > > > > Drivers then advertise that metadata can be extracted by setting this > dynamic > > flag in each mbuf. > > > > The application then calls rte_flow_get_restore_info() only when required. > > > > Link: http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8- > > [email protected]/ > > Signed-off-by: David Marchand <[email protected]> > > We did not notice the degradation, so: > Acked-by: Viacheslav Ovsiienko <[email protected]>
Acked-by: Ori Kam <[email protected]>
