On Tue, Jun 20, 2023 at 12:32 PM Kevin Traynor <ktray...@redhat.com> wrote:
>
> On 20/06/2023 07:56, David Marchand wrote:
> > On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob <jerinjac...@gmail.com> wrote:
> >>
> >> On Tue, Jun 20, 2023 at 2:17 AM David Marchand
> >> <david.march...@redhat.com> wrote:
> >>>
> >>> We forgot to add graph unit tests to the CI testsuites.
> >>>
> >>> Signed-off-by: David Marchand <david.march...@redhat.com>
> >>
> >> Could we add Fixes: ?
> >> Either way,
> >> Acked-by: Jerin Jacob <jer...@marvell.com>
> >
> > Indeed.
> > I don't think the graph unit tests and code changed much, so it should
> > be ok to backport down to 20.11 and enable these ut in the CI.
> >
> >
>
> Sounds ok to me to add "Fixes:" tag and backport. If they pass, great -
> if they don't, the graph maintainers would need to spend time updating
> the tests etc or we could just drop the patch.
Modulo some easy to fix conflict when backporting, the graph tests pass fine:
- 20.11:
2023-06-20T11:30:44.7171265Z 87/96 DPDK:fast-tests / graph_autotest
OK 0.13 s
2023-06-20T11:30:44.7171724Z 88/96 DPDK:fast-tests / node_list_dump
OK 0.13 s
- 21.11:
2023-06-20T11:32:37.2132951Z 90/101 DPDK:fast-tests / graph_autotest
OK 0.17 s
2023-06-20T11:32:37.2133397Z 91/101 DPDK:fast-tests / node_list_dump
OK 0.17 s
- 22.11:
2023-06-20T11:50:48.2519983Z 92/106 DPDK:fast-tests / graph_autotest
OK 0.17 s
2023-06-20T11:50:48.2520344Z 93/106 DPDK:fast-tests / node_list_dump
OK 0.17 s
--
David Marchand
