2015-11-24 09:43, Victor Kaplansky: > Yuanhan, looks fine. Thanks for handling this. > -- Victor > > On Tue, Nov 24, 2015 at 03:25:35PM +0800, Yuanhan Liu wrote: > > From: Victor Kaplansky <victork at redhat.com> > > > > The VHOST_USER_SET_VRING_ENABLE request was sent for each queue-pair. > > However, it's changed to be sent per queue in the queue-pair by QEMU > > commit dc3db6ad ("vhost-user: start/stop all rings"). The change > > is reasonable, as we send all other request per queue, instead of > > queue-pair. > > > > Hence we should do proper changes to adapt to the QEMU change here. > > Otherwise, a segfault will be triggered when last TX queue was enabled. > > > > [ commit log reword -- Yuanhan Liu ] > > > > Signed-off-by: Victor Kaplansky <victork at redhat.com> > > Acked-by: Yuanhan Liu <yuanhan.liu at linux.intel.com> > > --- > > > > v2: invoke vring_state_changed() callback per-vring as well > > > > This fixes a fatal issue, without that MQ will not work properly. > > Seems that Victor is busy at something else (or out of office so > > far), hence I sent v2 on behalf of him.
Applied, thanks