On Tue, Nov 24, 2015 at 06:44:36PM +0100, Thomas Monjalon wrote: > Thanks for the idea > > 2015-11-06 13:48, Ferruh Yigit: > > post-merge: Same script as "post-commit", but triggered after git pull > > A symbolic link would be sufficient. > As it must be installed in the git hooks (probably making a symbolic link), > duplicating the file is not needed at all. > OK
> > pre-commit: Does a checkpatch check before commit started. If script > > finds any error it will print warnings and fails. If checkpatch > > fails commit also fails. This guaranties every commit pass checkpatch. > > Default script is <dpdk>/scripts/checkpatch.pl but this can be > > changed by RTE_CHECKPATCH environment variable. Also a default list > > of checkpatch ignore items defined, new ones can be added by IGNORE > > environment variable. > > Please use the new scripts/checkpatches.sh: > http://dpdk.org/dev/patchwork/patch/9036/ > OK, better to use that script, to prevent duplicated IGNORE flag and checkpatch.pl location maintenance. > > This script can bypassed by commit "--no-verify" argument. > > Could you document the --no-verify option in the script? > This is git feature, with that flag script not called at all, I will add this comment into script. > > Deployment: > > To make scripts active they need to be in <dpdk>/.git/hooks folder. > > Alternatively "deploy.sh" script can be used, it simply copies all > > scripts into proper folder. Script names are significant and > > shouldn't changed. > > Why not using symbolic links? > Yes we can use symbolic links. I will send updated patch. Thanks for the review, ferruh
